ci: test against Ruby 4.0 and ruby-head#133
Merged
Merged
Conversation
Extend the CI matrix to cover newer Ruby versions so we catch incompatibilities early. Adds Ruby 3.5 to the supported matrix and a non-blocking ruby-head build (continue-on-error) to surface upcoming breakage without failing the suite. Also sets fail-fast: false so one version failing doesn't cancel the rest of the matrix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Ruby 3.5 never shipped as a stable release; the December 2025 release was branded Ruby 4.0. Point the matrix at the actual current stable (4.0) instead of the 3.5 preview line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
etagwerker
changed the title
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
terminal-table 4.0 requires unicode-display_width ~> 3.0, which conflicts with every rubocop that still supports Ruby 2.7 (needs < 3.0). Bundler silently backtracked rubocop to 0.7.2, which lacks rubocop/rake_task and broke the suite on 2.6/2.7. terminal-table 3.x works on Ruby 4.0, so the 4.0 bump was unnecessary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Skunk::Config is a process-global singleton. config_test.rb mutated Config.formats but only reset in setup, so it leaked [:html, :json] into other files. Under minitest's randomized order this intermittently failed argv_test.rb's 'defaults to console format' expectation (seen on the Ruby 3.2 CI job). Reset Config in config_test teardown and before/after the argv formats tests so the suite is order-independent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JuanVqz
approved these changes
Jul 3, 2026
JuanVqz
left a comment
JuanVqz
left a comment
Member
There was a problem hiding this comment.
looks good!
@etagwerker do you think is worth adding back support for Ruby 2.3?
Member
Author
@JuanVqz I don't think that's necessary. It's getting harder and harder to support ancient rubies. |
Member
|
@etagwerker sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the CI test matrix in
.github/workflows/main.ymlto cover more modern Ruby versions.continue-on-errorso upcoming breakage is visible without failing the suitefail-fast: falseso one version failing doesn't cancel the rest of the matrixWhy
The matrix currently tops out at Ruby 3.4. Ruby 4.0 shipped on December 25, 2025 (the 3.5 line never reached a stable release), so the suite should run against it. Running
headas well lets us catch incompatibilities before the next release.Notes
Opening as a draft to see how the suite behaves on the newer versions before marking it ready for review.
🤖 Generated with Claude Code