Skip to content

Re-enable safe checkout action#1497

Merged
calad0i merged 1 commit into
mainfrom
ci-checkout
Jun 30, 2026
Merged

Re-enable safe checkout action#1497
calad0i merged 1 commit into
mainfrom
ci-checkout

Conversation

@jmitrevs

Copy link
Copy Markdown
Contributor

Description

Checkout v7 made the default behavior safer for pull_request_target events in the CI. We verified that the action is safe, so we are re-enabling the behavior. Please check our assessment.

Type of change

  • Other (Specify) - CI

Tests

The CI should work after merging.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs

Copy link
Copy Markdown
Contributor Author

The KerasV3 pytest failure seems unrelated to this PR, so rerunning the test. Please look at my change to see if it seems the right way to do it, and I would suggest we try to merge today since this is holding up testing other PRs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the fork-PR “update branch” workflow to explicitly re-enable actions/checkout@v7’s ability to check out a fork PR’s head SHA in a pull_request_target-triggered workflow, gated by a maintainer-applied label.

Changes:

  • Re-enables unsafe PR head checkout in pull_request_target context by setting allow-unsafe-pr-checkout: true.
  • Keeps the existing label + fork-only guard and continues pushing the PR head SHA to an internal pr/<number> branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@calad0i

calad0i commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The qkeras pytest failure on accessing nonexistent envvar do seem to be irrelevant, but somehow not failing on the master. Test env regression outside repo?

@calad0i calad0i added the please test Trigger testing by creating local PR branch label Jun 30, 2026
@jmitrevs

Copy link
Copy Markdown
Contributor Author

The qkeras pytest error is due to the qkeras3 not fixed versionwise. A new version caused the error. The issue is fixed in #1499 and unrelated to this PR, so I would recommend merging this.

@calad0i calad0i left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure is upstream, unrelated.

@calad0i calad0i merged commit b98439c into main Jun 30, 2026
6 of 8 checks passed
@calad0i calad0i deleted the ci-checkout branch June 30, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please test Trigger testing by creating local PR branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants