Skip to content

Add Dockerfile-go#1828

Merged
anthony-gomez-fastly merged 1 commit into
fastly:mainfrom
mschfh:dockerfile-golang
Jun 24, 2026
Merged

Add Dockerfile-go#1828
anthony-gomez-fastly merged 1 commit into
fastly:mainfrom
mschfh:dockerfile-golang

Conversation

@mschfh

@mschfh mschfh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Change summary

Adds a Dockerfile-go to the repo, mirroring the existing Dockerfile-node and Dockerfile-rust but based on the golang:latest image. Like the others, this is a convenience Dockerfile that users can build to get a container with the Fastly CLI installed.

Build/run usage is documented in comments at the bottom of the file:

docker build -t fastly/cli/go . -f ./Dockerfile-go
docker run -v $PWD:/app -it -p 7676:7676 fastly/cli/go compute serve --addr="0.0.0.0:7676"

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

User Impact

Adds a Go-based Dockerfile option alongside the existing Node and Rust ones for users who prefer to build their own Fastly CLI container. No impact on existing functionality or users.

Are there any considerations that need to be addressed for release?

None. No breaking changes, and the image is not part of any build or release pipeline.

@mschfh mschfh force-pushed the dockerfile-golang branch from 955a76f to 2476631 Compare June 24, 2026 07:26
@mschfh mschfh marked this pull request as ready for review June 24, 2026 07:26
@mschfh mschfh requested a review from a team as a code owner June 24, 2026 07:26

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for your contribution! LGTM, once @kpfleming reviews we can see about merging

@kpfleming kpfleming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this being merged as-is, but it (of course) suffers from the same issues that the others do. The example command for using the image is ... compute serve, which means that Viceroy will have to be downloaded and that sort of defeats the purpose of using a container image since it isn't self-contained and requires Internet access at runtime (and the Viceroy binary will have to be downloaded every time, unlike a local CLI installation where it will only be downloaded once).

If the CLI had some command which could be used to trigger the download of the ancillary binaries that could be used in the Dockerfile to avoid this problem... but it doesn't :-)

@anthony-gomez-fastly anthony-gomez-fastly merged commit 27987db into fastly:main Jun 24, 2026
10 checks passed
@mschfh mschfh deleted the dockerfile-golang branch June 24, 2026 18:05
@mschfh

mschfh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@kpfleming #1833 adds a install-viceroy command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants