test: increase coverage to 100% and improvements#159
Open
Tony133 wants to merge 3 commits into
Open
Conversation
Member
Author
Tony133
marked this pull request as ready for review
July 17, 2026 08:53
Member
|
Who discretely rewrote this package in typescript while nobody was watching? |
| "removeComments": true, | ||
| "noUnusedLocals": true | ||
| "noUnusedLocals": true, | ||
| "skipLibCheck": true |
Tony133
changed the title
Tony133
force-pushed
the
test/improve-coverage
branch
from
July 17, 2026 15:23
0faaf9b to
cbb57c8
Compare
mcollina
requested changes
Jul 17, 2026
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
I would recommend we switch to strip types and esm
Member
Author
Agreed on the direction, but I'll split it into a separate PR since it's a breaking change (major bump, ESM-only, touches index.ts and the test setup). This one's just the files fix and test coverage; will follow up with the ESM/strip-types conversion separately, ok ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
testsintest, so as to align the folders with the other fastify pluginseslint.config.jsandtsconfig.jsonfor the build