Fix compile error in clang<10: fails on pragma -Wc++20-extensions#388
Merged
Conversation
This fixes a compile error in all clang versions lower than 10, triggered by the use of the pragma ignore with what is an unknown warning on those compiler versions: ``` /__w/ext/fast_float/include/fast_float/parse_number.h:361:34: error: unknown warning group '-Wc++20-extensions', ignored [-Werror,-Wunknown-pragmas] ``` The fix requires looking at __clang_major__, which is unfortunately different in Apple, so a version dispatch is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a compile error introduced in #387.
The error happens in all clang versions below 10, and is triggered by the use of the pragma ignore with what is an unknown warning on those compilers:
The fix requires looking at
__clang_major__, which is unfortunately different in Apple, so a version dispatch is required.