Fix OptionHighlighter regex incorrectly highlighting comparison operators as metavars - #1941
Open
eknathdj wants to merge 1 commit into
Open
Fix OptionHighlighter regex incorrectly highlighting comparison operators as metavars#1941eknathdj wants to merge 1 commit into
eknathdj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1637 (via discussion)
Problem
OptionHighlighterinrich_utils.pyuses the regex\<[^\>]+\>for thetypesgroup, which greedily matches everything between the first<and the next>in a help string. When a CLI option's help text contains comparison operators (e.g."Operators: <= (less/equal) and > (greater)"), the entire span<= (less/equal) and >gets incorrectly highlighted as a metavar type.Fix
Replace the regex with
\<\S(?:[^\>]*\S)?\>, which requires non-whitespace characters immediately after<and before>. This correctly:<= (less/equal) and >(space before>)<FILENAME>and<str>DateTimeformat metavar<%Y-%m-%d|%Y-%m-%dT%H:%M:%S|%Y-%m-%d %H:%M:%S>which contains internal spaces but has non-whitespace boundariesVerified against typer 0.27.1 on Python 3.14: broken render vs fixed render confirmed.
Disclosure
This fix was developed with AI assistance (GitHub Copilot). The bug analysis, regex design, edge case identification (DateTime metavar), and local verification were human-reviewed.