♻️ Remove redundant item deletion logic in backend/app/api/routes/users.py‎

[raphaeltannous]

Hey!

Removed redundant manual item deletion in the user deletion endpoint, since the SQLModel relationship already has ON DELETE CASCADE configured, which automatically deletes all related items when a user is deleted.

full-stack-fastapi-template/backend/app/models.py

Lines 93 to 95 in bba8d07

	owner_id: uuid.UUID = Field(
	foreign_key="user.id", nullable=False, ondelete="CASCADE"
	)

[YuriiMotov]

Makes sense!
But we should then add tests that check that items are also deleted.
Currently tests don't check that: https://github.com/fastapi/full-stack-fastapi-template/blob/master/backend/tests/api/routes/test_users.py

[raphaeltannous]

Makes sense! But we should then add tests that check that items are also deleted. Currently tests don't check that: https://github.com/fastapi/full-stack-fastapi-template/blob/master/backend/tests/api/routes/test_users.py

Hey! I've added 2 tests to check that the items are deleted.

[raphaeltannous]

LGTM!

I would simplify new added tests by excluding part that is already covered by previous tests

Updated.

Found an issue in the test implementation

[raphaeltannous]

You are right! I did not notice that.

I created create_random_item_for_user(db: Session, owner_id: uuid.UUID) -> Item, and used it. I also added an assertion for the item creation.

[YuriiMotov]

LGTM!

@raphaeltannous, thanks!
Passing this to Sebastian