Point TEST_RUNNER at the module the runner actually lives in - #854
Merged
Conversation
TEST_RUNNER in boilerplate.py referenced app.test.disable_test_command_runner.DisableTestCommandRunner, but no app/test/ package exists — the class lives in app/testing/runner.py. In generated projects, ./manage.py test therefore crashed with an ImportError instead of raising the intended CommandError telling the user to run pytest via make test. Also update the README reference to the same long-gone app.test package: the DRF test client is app.testing.api, its fixtures are as_user and as_anon, and the example file is test_whoami.py. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST_RUNNER in
{{ cookiecutter.name }}/src/app/conf/boilerplate.pypointed atapp.test.disable_test_command_runner.DisableTestCommandRunner, but noapp/test/package exists — the class lives atsrc/app/testing/runner.py.As a result, running
./manage.py testin a generated project died with an ImportError instead of the intended friendlyCommandError: Pytest here. Run it withmake test``.The fix points the setting at
app.testing.runner.DisableTestCommandRunner. The README reference to the same long-goneapp.testpackage is updated alongside it (app.testing.api,as_user/as_anonfixtures,test_whoami.py).🤖 Generated with Claude Code