Skip to content

WIP: Run Emscripten RestClient fetches on a worker thread #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
drslebedev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Run Emscripten RestClient fetches on a worker thread #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/client/include/ClientContext.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,7 @@ class ClientContext {
return false;
}
auto &c = getClientCtx(cmd.topic);
#ifdef EMSCRIPTEN
// this is necessary for fetches to actually be called, as the new thread will start/init/end and then go into js runtime to fetch
std::thread ql{ [&c, cmd]() {
#endif
c.request(cmd);
#ifdef EMSCRIPTEN
} };
ql.join();
#endif
c.request(std::move(cmd));
return false;
});
}
Expand Down
Loading
Loading