improving code quality by refactoring#399
Open
mitimugdho wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files changed: CircuitBreakerImpl.java, RetryPolicyExecutor.java, Functions.java, Fallback.java, FailsafeExecutor.java
Files added: RetryDelayCalculator.java, FunctionAdapters.java, ExecutorDelegation.java
CircuitBreakerImpl.java:165 — NonExhaustiveSwitch
The transitionTo() method mixed locking with an inline switch over State that selected which CircuitState implementation to construct, that switch had no default case.
Extracted state construction into its own createState(State, ExecutionContext) method with an explicit default branch throwing IllegalArgumentException. transitionTo() now only handles locking and listener dispatch; createState() is independently testable without driving a full transition.
RetryPolicyExecutor.onFailure() — responsibility extraction
onFailure() combined three unrelated concerns: a 4-step delay computation, retry-exhaustion decisions, and event-listener dispatch.
Extracted the delay pipeline into a new class, RetryDelayCalculator, which now owns that state and the four delay-adjustment steps. RetryPolicyExecutor delegates to it via a single call.
Functions.java — God Class split
Functions was a 300 line package-private utility class combining three unrelated responsibilities with no shared state.
Split into Functions (execution wiring, unchanged scope otherwise), ExecutorDelegation (executor delegation), and FunctionAdapters (type adaptation).