Fix ISL "Goto" hanging in OSS by always replying to fetchQeFlag#1353
Closed
pfei-sa wants to merge 1 commit into
Closed
Fix ISL "Goto" hanging in OSS by always replying to fetchQeFlag#1353pfei-sa wants to merge 1 commit into
pfei-sa wants to merge 1 commit into
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D111660481. (Because this pull request was imported automatically, there will not be any future comments.) |
The "Goto" button (and the right-click "Goto" context-menu item) in `sl web` silently did nothing in OSS builds (facebook#1332). Both call gotoAction(), which awaits runWarningChecks(), whose last check awaits getQeFlag('isl_rebase_onto_warm_button'). getQeFlag posts a `fetchQeFlag` message and awaits a `fetchedQeFlag` reply. The server handler was `Internal.fetchQeFlag?.(...).then(...)`; in OSS there is no Internal.fetchQeFlag, so the optional chain short-circuits and no reply is ever posted. nextMessageMatching has no timeout, so getQeFlag never resolves, gotoAction never dispatches the GotoOperation, and Goto appears dead. This regressed when the "rebase onto warm" work started passing a hardcoded QE flag name (bypassing the usual OSS null-gating). Fix: always reply to fetchQeFlag, defaulting to `false` when Internal.fetchQeFlag is unavailable (the correct OSS semantics), so the client never hangs. Note: the sibling handlers fetchFeatureFlag and bulkFetchFeatureFlags share the same `Internal.x?.(...).then(...)` short-circuit shape. They are not currently reachable with a missing reply in OSS (feature flags are gated client-side via Internal.featureFlags?.), so this focused change leaves them as-is; they should get the same "always reply" guard as a follow-up. Fixes facebook#1332
|
@pfei-sa has updated the pull request. You must reimport the pull request before landing. |
|
This pull request has been merged in b41d6d1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Goto" button (and the right-click "Goto" context-menu item) in
sl websilently did nothing in OSS builds (#1332). Both call gotoAction(), which awaits
runWarningChecks(), whose last check awaits
getQeFlag('isl_rebase_onto_warm_button').
getQeFlag posts a
fetchQeFlagmessage and awaits afetchedQeFlagreply. Theserver handler was
Internal.fetchQeFlag?.(...).then(...); in OSS there is noInternal.fetchQeFlag, so the optional chain short-circuits and no reply is ever
posted. nextMessageMatching has no timeout, so getQeFlag never resolves,
gotoAction never dispatches the GotoOperation, and Goto appears dead. This
regressed when the "rebase onto warm" work started passing a hardcoded QE flag
name (bypassing the usual OSS null-gating).
Fix: always reply to fetchQeFlag, defaulting to
falsewhen Internal.fetchQeFlagis unavailable (the correct OSS semantics), so the client never hangs.
Note: the sibling handlers fetchFeatureFlag and bulkFetchFeatureFlags share the
same
Internal.x?.(...).then(...)short-circuit shape. They are not currentlyreachable with a missing reply in OSS (feature flags are gated client-side via
Internal.featureFlags?.), so this focused change leaves them as-is; they should
get the same "always reply" guard as a follow-up.
Fixes #1332