Skip to content

Add @Nullable to ScrollView getChildVisibleRect offset parameter #57075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cortinico wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

Add @Nullable to ScrollView getChildVisibleRect offset parameter #57075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import android.animation.ObjectAnimator;
import android.animation.ValueAnimator;
import android.annotation.SuppressLint;
import android.content.Context;
import android.graphics.Canvas;
import android.graphics.Color;
Expand Down Expand Up @@ -1054,7 +1055,8 @@ public void getClippingRect(Rect outClippingRect) {
}

@Override
public boolean getChildVisibleRect(View child, Rect r, android.graphics.Point offset) {
@SuppressLint("NullsafeMismatch")
public boolean getChildVisibleRect(View child, Rect r, @Nullable android.graphics.Point offset) {
return super.getChildVisibleRect(child, r, offset);
}

Expand Down
6 changes: 4 additions & 2 deletions ...ive/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactNestedScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ee631e2aaec71e0722c894a07f4f7022>>
* @generated SignedSource<<73693667f092b5c8a9f5b10c479e8174>>
*/

/**
Expand All @@ -23,6 +23,7 @@

import android.animation.ObjectAnimator;
import android.animation.ValueAnimator;
import android.annotation.SuppressLint;
import android.content.Context;
import android.graphics.Canvas;
import android.graphics.Color;
Expand Down Expand Up @@ -807,7 +808,8 @@ public void getClippingRect(Rect outClippingRect) {
}

@Override
public boolean getChildVisibleRect(View child, Rect r, android.graphics.Point offset) {
@SuppressLint("NullsafeMismatch")
public boolean getChildVisibleRect(View child, Rect r, @Nullable android.graphics.Point offset) {
return super.getChildVisibleRect(child, r, offset);
}

Expand Down
4 changes: 3 additions & 1 deletion ...ct-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import android.animation.ObjectAnimator;
import android.animation.ValueAnimator;
import android.annotation.SuppressLint;
import android.content.Context;
import android.graphics.Canvas;
import android.graphics.Color;
Expand Down Expand Up @@ -799,7 +800,8 @@ public void getClippingRect(Rect outClippingRect) {
}

@Override
public boolean getChildVisibleRect(View child, Rect r, android.graphics.Point offset) {
@SuppressLint("NullsafeMismatch")
public boolean getChildVisibleRect(View child, Rect r, @Nullable android.graphics.Point offset) {
return super.getChildVisibleRect(child, r, offset);
}

Expand Down
Loading