Skip to content

Remove deprecated Instance type aliases (Flow) #57053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated Instance type aliases (Flow) #57053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/react-native/Libraries/Components/ScrollView/ScrollView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ export interface ScrollViewInstance
extends HostInstance,
ScrollViewImperativeMethods {}

/** @deprecated Use ScrollViewInstance instead */
export type PublicScrollViewInstance = ScrollViewInstance;

type InnerViewInstance = React.ElementRef<typeof View>;

export type ScrollViewPropsIOS = Readonly<{
Expand Down
3 changes: 0 additions & 3 deletions packages/react-native/Libraries/Modal/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ type ModalEventDefinitions = {

export type ModalInstance = HostInstance;

/** @deprecated Use ModalInstance instead */
export type PublicModalInstance = ModalInstance;

const ModalEventEmitter =
Platform.OS === 'ios' && NativeModalManager != null
? new NativeEventEmitter<ModalEventDefinitions>(
Expand Down
7 changes: 3 additions & 4 deletions ...ages/rn-tester/js/examples/IntersectionObserver/IntersectionObserverExplicitRootScroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
* @flow strict-local
*/

import type {HostInstance} from 'react-native';
import type {PublicScrollViewInstance} from 'react-native/Libraries/Components/ScrollView/ScrollView';
import type {HostInstance, ScrollViewInstance} from 'react-native';
import type {ViewStyleProp} from 'react-native/Libraries/StyleSheet/StyleSheet';
import type IntersectionObserverType from 'react-native/src/private/webapis/intersectionobserver/IntersectionObserver';

Expand Down Expand Up @@ -42,8 +41,8 @@ component IntersectionObserverExplicitRootScrollExample() {
const [observationRoot, setObservationRoot] = useState<?HostInstance>(null);

const [showMargin, setShowMargin] = useState(true);
const roofRef: React.RefSetter<PublicScrollViewInstance> = useCallback(
(rootNode: ?PublicScrollViewInstance) => {
const roofRef: React.RefSetter<ScrollViewInstance> = useCallback(
(rootNode: ?ScrollViewInstance) => {
if (rootNode != null) {
setObservationRoot(rootNode);
}
Expand Down
Loading