Skip to content

Respect JS responder inside Fabric ScrollView #57050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sorinc03 wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −3
Open

Respect JS responder inside Fabric ScrollView #57050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,24 @@ - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompo
* Returns whether or not the scroll view interaction should be blocked because
* JavaScript was found to be the responder.
*/
- (BOOL)_shouldDisableScrollInteraction
- (BOOL)_shouldDisableScrollInteractionForContentView:(UIView *)contentView
{
UIView *view = contentView;
while (view) {
if ([view respondsToSelector:@selector(isJSResponder)]) {
BOOL isJSResponder = ((UIView<RCTComponentViewProtocol> *)view).isJSResponder;
if (isJSResponder) {
return YES;
}
}

if (view == self) {
break;
}

view = view.superview;
}

UIView *ancestorView = self.superview;

while (ancestorView) {
Expand Down Expand Up @@ -736,11 +752,11 @@ - (void)scrollViewWillEndDragging:(UIScrollView *)scrollView
static_cast<const ScrollViewEventEmitter &>(*_eventEmitter).onScrollEndDrag(metrics);
}

- (BOOL)touchesShouldCancelInContentView:(__unused UIView *)view
- (BOOL)touchesShouldCancelInContentView:(UIView *)view
{
// Historically, `UIScrollView`s in React Native do not cancel touches
// started on `UIControl`-based views (as normal iOS `UIScrollView`s do).
return ![self _shouldDisableScrollInteraction];
return ![self _shouldDisableScrollInteractionForContentView:view];
}

- (void)scrollViewDidScroll:(UIScrollView *)scrollView
Expand Down
Loading