Skip to content

Re-emit keyboardDidShow on IME height change #56486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanleedev wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −14
Open

Re-emit keyboardDidShow on IME height change #56486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,7 @@ private class CustomGlobalLayoutListener implements ViewTreeObserver.OnGlobalLay
private final Rect mVisibleViewArea;

private boolean mKeyboardIsVisible = false;
private int mKeyboardHeight = 0;
private int mDeviceRotation = 0;

/* package */ CustomGlobalLayoutListener() {
Expand All @@ -957,13 +958,17 @@ private void checkForKeyboardEvents() {
}

boolean keyboardIsVisible = rootInsets.isVisible(WindowInsetsCompat.Type.ime());
if (keyboardIsVisible != mKeyboardIsVisible) {
mKeyboardIsVisible = keyboardIsVisible;
Insets barInsets = rootInsets.getInsets(WindowInsetsCompat.Type.systemBars());
Insets barInsets = rootInsets.getInsets(WindowInsetsCompat.Type.systemBars());

if (keyboardIsVisible) {
Insets imeInsets = rootInsets.getInsets(WindowInsetsCompat.Type.ime());
int height = imeInsets.bottom - barInsets.bottom;
if (keyboardIsVisible) {
Insets imeInsets = rootInsets.getInsets(WindowInsetsCompat.Type.ime());
int height = imeInsets.bottom - barInsets.bottom;

// Re-emit on height change while keyboard stays visible (e.g., emoji
// panel toggle); JS consumers cache endCoordinates from keyboardDidShow.
if (!mKeyboardIsVisible || height != mKeyboardHeight) {
mKeyboardIsVisible = true;
mKeyboardHeight = height;

ViewGroup.LayoutParams rootLayoutParams = getRootView().getLayoutParams();
Assertions.assertCondition(rootLayoutParams instanceof WindowManager.LayoutParams);
Expand All @@ -981,15 +986,18 @@ private void checkForKeyboardEvents() {
PixelUtil.toDIPFromPixel(mVisibleViewArea.left),
PixelUtil.toDIPFromPixel(mVisibleViewArea.width()),
PixelUtil.toDIPFromPixel(height)));
} else {
sendEvent(
"keyboardDidHide",
createKeyboardEventPayload(
PixelUtil.toDIPFromPixel(mVisibleViewArea.bottom + barInsets.bottom),
0,
PixelUtil.toDIPFromPixel(mVisibleViewArea.width()),
0));
}
} else if (mKeyboardIsVisible) {
mKeyboardIsVisible = false;
mKeyboardHeight = 0;

sendEvent(
"keyboardDidHide",
createKeyboardEventPayload(
PixelUtil.toDIPFromPixel(mVisibleViewArea.bottom + barInsets.bottom),
0,
PixelUtil.toDIPFromPixel(mVisibleViewArea.width()),
0));
}
}

Expand Down
Loading