fix(jest): mock getBoundingClientRect on host components in tests#56477
Open
HarshitMadhav wants to merge 1 commit intofacebook:mainfrom
Open
fix(jest): mock getBoundingClientRect on host components in tests#56477HarshitMadhav wants to merge 1 commit intofacebook:mainfrom
HarshitMadhav wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Jest mocks for host components (
MockNativeMethods,mockNativeComponent) exposedmeasure,measureInWindow,measureLayout,setNativeProps,focus, andblur, but notgetBoundingClientRect. In production,ReadOnlyElement/ReactNativeElementimplementsgetBoundingClientRect(); refs fromreact-test-rendererin unit tests therefore threwTypeError: getBoundingClientRect is not a functionwhen user code called it (see #54916).This change adds a
getBoundingClientRectmock that returns a zero-valued DOMRect-like object (x,y,width,height,top,left,right,bottom), matching the fallback behavior when there is no native node. Tests were added for the mock helpers and for callinggetBoundingClientRecton a mockedViewref viareact-test-renderer.Fixes #54916.
Changelog:
[INTERNAL] [FIXED] - Mock getBoundingClientRect on Jest host component refs so unit tests match ReadOnlyElement and no longer throw when calling ref.getBoundingClientRect().
Test Plan:
Ran:
yarn test packages/jest-preset/jest/__tests__/All tests passed, including
mockNativeMethods-test.js,getBoundingClientRect-test.js, andsetup-test.js.