Skip to content

[Android] Use Hermes V1 by default #56476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cipolleschi wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

[Android] Use Hermes V1 by default #56476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ if (project.findProperty("react.internal.useHermesStable")?.toString()?.toBoolea
)
}

hermesSubstitution = "$hermesCompilerVersion-SNAPSHOT" to "Users opted to use hermes nightly"
val hermesV1Enabled =
project.findProperty("hermesV1Enabled")?.toString()?.toBoolean() ?: true
// Hermes V1 stable releases are published without the -SNAPSHOT suffix.
// Legacy nightly builds use -SNAPSHOT.
val resolvedVersion =
if (hermesV1Enabled) hermesCompilerVersion else "$hermesCompilerVersion-SNAPSHOT"
hermesSubstitution = resolvedVersion to "Users opted to use hermes nightly"
} else {
logger.warn(
"""
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/sdks/hermes-engine/version.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
HERMES_VERSION_NAME=1000.0.0
HERMES_V1_VERSION_NAME=250829098.0.11
HERMES_V1_VERSION_NAME=250829098.0.12
6 changes: 3 additions & 3 deletions scripts/try-set-nightly-hermes-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ function main() {
const hermesCompilerVersion = packageJson.dependencies['hermes-compiler'];

if (hermesCompilerVersion === '0.0.0') {
console.log(`Hermes compiler version not set. Updating to the latest nightly release.`);
execSync('yarn workspace react-native add hermes-compiler@nightly --exact', { stdio: 'inherit' });
console.log(`Hermes compiler version not set. Updating to the latest-v1 release.`);
execSync('yarn workspace react-native add hermes-compiler@latest-v1 --exact', { stdio: 'inherit' });
} else {
console.log(`Hermes compiler version set to ${hermesCompilerVersion}. Not setting nightly hermes.`);
console.log(`Hermes compiler version set to ${hermesCompilerVersion}. Not setting hermes.`);
}
}

Expand Down
Loading