unify module prefix so __unknown__ files count under --public-only (#4157)#4157
Open
kinto0 wants to merge 2 commits into
Open
unify module prefix so __unknown__ files count under --public-only (#4157)#4157kinto0 wants to merge 2 commits into
kinto0 wants to merge 2 commits into
Conversation
Contributor
|
@kinto0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112166629. |
…oad the correct commit data. Differential Revision: D111830464
This comment has been minimized.
This comment has been minimized.
kinto0
added a commit
to kinto0/pyrefly
that referenced
this pull request
Jul 15, 2026
…acebook#4157) Summary: Pull Request resolved: facebook#4157 Make coverage's `module_prefix()` unconditional so `__unknown__` fallback modules get the `__unknown__.` prefix like every other module. Why: under `--public-only`, these files silently reported "0 of N typable" — symbols were stored bare while the public-FQN filter expects the prefixed form, so all got dropped. Differential Revision: D112166629
kinto0
force-pushed
the
export-D112166629
branch
from
20cd029 to
c613227
Compare
meta-codesync
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
kinto0
added a commit
to kinto0/pyrefly
that referenced
this pull request
Jul 15, 2026
…acebook#4157) Summary: Pull Request resolved: facebook#4157 Make coverage's `module_prefix()` unconditional so `__unknown__` fallback modules get the `__unknown__.` prefix like every other module. Why: under `--public-only`, these files silently reported "0 of N typable" — symbols were stored bare while the public-FQN filter expects the prefixed form, so all got dropped. Differential Revision: D112166629
kinto0
force-pushed
the
export-D112166629
branch
from
c613227 to
0781873
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
…acebook#4157) Summary: Pull Request resolved: facebook#4157 Make coverage's `module_prefix()` unconditional so `__unknown__` fallback modules get the `__unknown__.` prefix like every other module. Why: under `--public-only`, these files silently reported "0 of N typable" — symbols were stored bare while the public-FQN filter expects the prefixed form, so all got dropped. Differential Revision: D112166629
kinto0
force-pushed
the
export-D112166629
branch
from
0781873 to
7997eca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Make coverage's
module_prefix()unconditional so__unknown__fallback modules get the__unknown__.prefix like every other module.Why: under
--public-only, these files silently reported "0 of N typable" — symbols were stored bare while the public-FQN filter expects the prefixed form, so all got dropped.Differential Revision: D112166629