Always print coverage findings in pyrefly coverage check --fail-under=#4156
Open
jorenham wants to merge 2 commits into
Open
Always print coverage findings in pyrefly coverage check --fail-under=#4156jorenham wants to merge 2 commits into
pyrefly coverage check --fail-under=#4156jorenham wants to merge 2 commits into
Conversation
jorenham
changed the title
pyrefly coverage
jorenham
changed the title
pyrefly coveragepyrefly coverage check --fail-under=
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now,
pyrefly coverage report --fail-under=<something below 100>does not print the findings if the coverage is above the threshold. I think it would be more useful if those findings would be printed regardless of whether it passes (i.e. exits 0). And if the user doesn't want to see those findings for some reason, then they could always use the existing--output-format=omit-errorsflag to disable this.Test Plan
Manually verified that the missing coverage warnings are now always emitted.