fix(stubgen): extract statements from try blocks and expand TYPE_CHECKING recognition#4143
Closed
tobyh-canva wants to merge 1 commit into
Closed
fix(stubgen): extract statements from try blocks and expand TYPE_CHECKING recognition#4143tobyh-canva wants to merge 1 commit into
try blocks and expand TYPE_CHECKING recognition#4143tobyh-canva wants to merge 1 commit into
Conversation
…HECKING` recognition
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D111931590. |
kinto0
approved these changes
Jul 15, 2026
kinto0
left a comment
kinto0
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
@yangdanny97 merged this pull request in 41727d4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates stubgen to address two of the three limitations identified in #3888:
TYPE_CHECKINGguards which are part of a larger boolean expression, e.g.if TYPE_CHECKING or not USE_EXTENSIONS, should have statements extracted.tryblocks should be extracted.Works towards fixing #3888.
I'd prefer to handle the third limitation (
sysconditionals) in a separate PR, as it's considerably more complex.Test Plan
python3 test.py