try fix Pyrefly crashes VSCode when allocating memory on glibc 2.17 #1636#4122
Open
asukaminato0721 wants to merge 1 commit into
Open
try fix Pyrefly crashes VSCode when allocating memory on glibc 2.17 #1636#4122asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
Contributor
|
cool! do you have a source for the musl change? and are we able to reproduce the issue -> fix resolution anywhere? |
Contributor
Author
|
The Linux x64 VS Code extension is indeed built for x86_64-unknown-linux-musl (source (ca7e66d)), and I confirmed that the published 0.42.2 binary is a static PIE using jemalloc. for the allocator change reason, jemalloc/jemalloc#1328 but it's hard to make a test for it... maybe @varchasgopalaswamy can have a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1636
Musl binaries, including the bundled Linux x64 VS Code binary, now use mimalloc instead of jemalloc, GNU Linux and macOS retain jemalloc.
Test Plan