Add safe mode recovery for sandbox crashes#3558
Open
fangyi-zhou wants to merge 1 commit into
Open
Conversation
The sandbox crash fallback could leave users trapped when the same persisted code immediately crashed wasm again after retrying. Add a sandbox-specific recovery path that keeps the user's files but pauses Pyrefly type checking so the crashing input can be edited. The fallback stores a session-scoped safe-mode flag, the sandbox skips wasm initialization and recheck while that flag is set, and the UI offers an explicit resume action once the user is ready to type check again.
Contributor
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D106426615. |
kinto0
approved these changes
May 27, 2026
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick follow up from #3539 regarding sandbox crashes, vibed coded a crash helmet called "safe mode"
Test Plan
Screen.Recording.2026-05-23.at.01.14.12.mov