fix(theme-classic): remove redundant sidebar label titles#11966
Merged
slorber merged 2 commits intoMay 28, 2026
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
approved these changes
May 28, 2026
Collaborator
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
I'm going to merge the minimal change because this is the correct fix
However, your unit test is way too complex for such a tiny change
I appreciate the disclosure of AI, but please do not contribute just for the sake of it to projects you barely use/understand, solving problems you do not even encounter yourself.
That kind of PR makes me lose time more than anything, and is usually not welcome.
| import type {Props as CategoryProps} from '@theme/DocSidebarItem/Category'; | ||
| import type {Props as LinkProps} from '@theme/DocSidebarItem/Link'; | ||
|
|
||
| jest.mock('@docusaurus/Link', () => { |
…ests__/index.test.tsx
slorber
added
pr: bug fix
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Fixes #11945.
WAVE reports redundant title text for docs sidebar labels because the label text is rendered both as visible text and as an identical
titleattribute. This removes the redundanttitleattributes from docs sidebar link and category label spans while preserving the existing visible label markup and styling.AI-assisted: I used AI assistance while preparing this PR and verified the resulting changes locally.
Test Plan
YARN_IGNORE_ENGINES=1 yarn test packages/docusaurus-theme-classic/src/theme/DocSidebarItem/__tests__/index.test.tsx --runInBandYARN_IGNORE_ENGINES=1 yarn eslint --cache --report-unused-disable-directives packages/docusaurus-theme-classic/src/theme/DocSidebarItem/Link/index.tsx packages/docusaurus-theme-classic/src/theme/DocSidebarItem/Category/index.tsx packages/docusaurus-theme-classic/src/theme/DocSidebarItem/__tests__/index.test.tsxyarn prettier --check packages/docusaurus-theme-classic/src/theme/DocSidebarItem/Link/index.tsx packages/docusaurus-theme-classic/src/theme/DocSidebarItem/Category/index.tsx packages/docusaurus-theme-classic/src/theme/DocSidebarItem/__tests__/index.test.tsxI also attempted
YARN_IGNORE_ENGINES=1 yarn workspace @docusaurus/theme-classic buildafter installing dependencies with scripts disabled, but it could not complete because local workspace packages such as@docusaurus/plugin-content-blog/clientand@docusaurus/plugin-content-docs/clienthad not been built in this checkout.Test links
Deploy preview: https://deploy-preview-11966--docusaurus-2.netlify.app/
Related issues/PRs