Skip to content

Apply review fixes for keypaths separator handling #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabiocaccamo merged 4 commits into from
Jul 7, 2026
+5 −6
Merged

Apply review fixes for keypaths separator handling #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
babefe7
Initial plan
Copilot Jul 7, 2026
420df7e
fix keypaths separator validation and test coverage
Copilot Jul 7, 2026
0a3d390
refine keypaths separator validation
Copilot Jul 7, 2026
c248664
finalize keypaths separator check
Copilot Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions benedict/core/keypaths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ def keypaths(
indexes: bool = False,
sort: bool = True,
) -> list[str]:
separator = separator or "."
if not type_util.is_string(separator):
if separator is None:
separator = "."
if not type_util.is_string(separator) or len(separator) == 0:
raise ValueError("separator argument must be a (non-empty) string.")
kls = keylists(d, indexes=indexes)
kps = [separator.join([f"{key}" for key in kl]) for kl in kls]
Expand Down
6 changes: 2 additions & 4 deletions tests/core/test_keypaths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def test_keypaths_with_invalid_separator(self) -> None:
with self.assertRaises(ValueError):
_ = _keypaths(i, separator=True) # type: ignore[arg-type]

def test_keypaths_without_separator(self) -> None:
def test_keypaths_with_none_separator(self) -> None:
i = {
"a": 1,
"b": {
Expand All @@ -120,9 +120,7 @@ def test_keypaths_without_separator(self) -> None:
},
},
}
# with self.assertRaises(ValueError):
# o = _keypaths(i, separator=None)
o = _keypaths(i)
o = _keypaths(i, separator=None)
r = [
"a",
"b",
Expand Down
Loading