Skip to content

Reject empty keypaths separator #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabiocaccamo merged 3 commits into from
Jul 7, 2026
+7 −4
Merged

Reject empty keypaths separator #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44ef834
Reject empty keypaths separator
CodingFeng101 Jun 30, 2026
0fcdb46
Use a single condition.
fabiocaccamo Jul 7, 2026
7c5f958
Merge branch 'main' into codex/small-fix
fabiocaccamo Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions benedict/core/keypaths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ def keypaths(
indexes: bool = False,
sort: bool = True,
) -> list[str]:
if separator is None:
separator = "."
if not type_util.is_string(separator) or len(separator) == 0:
separator = "." if separator is None else separator
if not type_util.is_string(separator) or not separator:
raise ValueError("separator argument must be a (non-empty) string.")
kls = keylists(d, indexes=indexes)
kps = [separator.join([f"{key}" for key in kl]) for kl in kls]
Expand Down
6 changes: 5 additions & 1 deletion tests/core/test_keypaths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ def test_keypaths_with_invalid_separator(self) -> None:
with self.assertRaises(ValueError):
_ = _keypaths(i, separator=True) # type: ignore[arg-type]

def test_keypaths_with_none_separator(self) -> None:
def test_keypaths_with_empty_separator(self) -> None:
with self.assertRaises(ValueError):
_ = _keypaths({"a": {"b": 1}}, separator="")

def test_keypaths_without_separator(self) -> None:
i = {
"a": 1,
"b": {
Expand Down
Loading