Skip to content

Material Laws - S-N curves#58

Draft
KarasTomas wants to merge 9 commits into
faberorg:mainfrom
KarasTomas:SN-curves
Draft

Material Laws - S-N curves#58
KarasTomas wants to merge 9 commits into
faberorg:mainfrom
KarasTomas:SN-curves

Conversation

@KarasTomas

Copy link
Copy Markdown
Collaborator

Pull request following Issues #56 and #57 implementing S-N curve models

@KarasTomas
KarasTomas requested a review from Vybornak2 November 24, 2025 15:19
@KarasTomas KarasTomas added the WIP Work In Progress label Nov 24, 2025

@Vybornak2 Vybornak2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some variable names should be adjusted according to nomenclature faber table, that is being created at the time of this review (dec 2025).

Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py Outdated
Comment thread src/fatpy/material_laws/sn_curve.py
@KarasTomas
KarasTomas marked this pull request as draft June 23, 2026 15:01
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fatpy/material_laws/sn_curve.py 97.14% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work In Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants