feat: add embedding ingestion and hybrid retrieval - #7
Merged
Merged
Conversation
Add ExperienceFinalizationService: one call that loads a completed captured run, evaluates its own closed verification round, checks host authorization and the host's storage decision, reflects, creates the record as Candidate, and commits its initial lifecycle event to Validated or Quarantined. Record, reflection and event IDs derive from the run, so a retry re-derives them and converges instead of duplicating. Required checks can now name the evaluator kind that may satisfy them, and Core and Storage.Postgres each expose a service-registration extension. The MAF adapter finalizes a fully captured run through the host's resolver. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Add IExperienceCandidateSource with a PostgreSQL implementation: scope, status and confidence filtering plus a full-text match over a generated tsvector column added by migration 0003. Core's ExperienceRetrievalService applies expiry and environment eligibility, then ranks candidates on relevance, confidence, recency, status and environment compatibility with configurable validated weights, exposing every normalized component and effective weight. Retrieval is bounded by a timeout that returns an empty result with a timeout signal rather than throwing, caller cancellation stays distinct, and a capped candidate pool is reported through Truncated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Add IExperienceEmbeddingIndex and a domain-typed embedding generator port, with a new AgentExperience.Storage.Postgres.Vectors package implementing them over plain Npgsql and Pgvector. Embeddings are derived data: indexing runs after the canonical commit, embeds only the sanitized retrieval summary of an eligible record, and writes conditionally on the record's exact revision, so a stale write is rejected and a deleted record is never recreated. Retrieval gains a vector channel merged with the text channel under the same eligibility, timeout and ceiling. A model or dimension mismatch, an unavailable provider, or a vector-channel failure produces an explicit flagged text-only result rather than an incompatible comparison. The vectors package owns and applies its own schema, so a text-only deployment never runs CREATE EXTENSION vector. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Story 2.6. Records become semantically findable, without the canonical path ever depending on a model provider.
ExperienceIndexingServiceembeds only its sanitized retrieval summary — task ID, task summary, reflection lesson — through a replaceable, domain-typed port.IEmbeddingGeneratornever reaches Abstractions or Core.HttpClienttimeout looks like.CREATE EXTENSION vector(a superuser operation). The HNSW index is created out of band, and a test proves the planner actually uses it.Route
Plain Npgsql with
Pgvector, which epics.md sanctions alongside the VectorData connector. The hybrid query must join embeddings to records (status and confidence live there), match optional scope fields withIS NOT DISTINCT FROM, and work against an unconstrainedvectorcolumn — none of which the connector expresses. Recorded with its reasoning in the spec.Review
Three reviewers raised 33 findings; 32 fixed, 1 deferred (a batch embedding overload for large reindexes). The serious ones: the schema forced pgvector on text-only hosts; ineligible records' text was being sent to a provider; a provider-side timeout returned an empty failure instead of the text answer; and the post-commit hook was unbounded.
Test plan
dotnet build --configuration Release: 0 warnings, 0 errorsdotnet test --configuration Release: 643 of 643 pass (Core 382, Postgres 125, Vectors 43). Locally withTESTCONTAINERS_RYUK_DISABLED=true.postgres:16migration proving text-only hosts need no extension.🤖 Generated with Claude Code