Fix devel-version suffix in bindings fallback messages#261
Open
CGMossa wants to merge 1 commit into
Open
Conversation
`retrieve_prebuild_bindings` interpolated `version_info.devel` (a `bool`) into its warning and panic where the `-devel`/`""` suffix belonged, so the messages printed nonsense such as "These may not work for R 4.6.0false." Compute the same `devel_suffix` already used by `get_r_bindings_filename` and use it in both messages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: replace this line with your own framing, in your own voice.
AI-written details
Summary
retrieve_prebuild_bindingsinterpolatedversion_info.devel(abool) where the-devel/""suffix belonged, so the messages printed nonsense such asThese may not work for R 4.6.0false.devel_suffixalready used byget_r_bindings_filenameand use it in both messages.Test plan
... These may not work for R 4.6.0.with no trailingfalse.Notes
Drafted by Claude (claude-opus-4-8). Reviewed by the author.