fix(HII-13198): Fix npm ci error#333
Open
dorin992 wants to merge 25 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the composite-actions/nodejs-generic-api/test-unit composite action to make npm authentication more reliable for unit-test runs and Docker-based vulnerability-scan image builds, especially when private packages are fetched during npm ci inside Docker.
Changes:
- Generates a runtime workspace
.npmrcfor the@hiiretailArtifact Registry scope and authenticates viagoogle-artifactregistry-auth. - Mirrors npm credentials to
~/.npmrcto support tools/environments that read home-level npm config. - Enables BuildKit and passes
.npmrcintodocker buildusing a BuildKit secret for the vulnerability-scan image build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the shared
test-unitcomposite action to make npm authentication reliable across services during vulnerability-scan image builds.What Changed
.npmrcwith the@hiiretailArtifact Registry scope.google-artifactregistry-authagainst that runtime.npmrcso credentials are written where the workflow expects them.$HOME/.npmrcfor compatibility with tools/environments that read home-level npm config.--secret id=npmrc,src=.npmrcWhy
Some services passed unit tests but failed in Docker image build (
npm ciinside Docker) withE401due to auth context mismatch between runner and container.Because repositories use different Dockerfile patterns (
COPY . .vs BuildKit secret consumption), the action needed a backward-compatible auth strategy that works for both.Outcome
This change improves cross-repo compatibility by supporting:
.npmrcbehavior, andIt reduces CI breakage without changing the expected pipeline stages or behavior.