Pass new session as extra param to Session reload and regenerate callbacks#907
Open
sgpinkus wants to merge 1 commit into
Open
Pass new session as extra param to Session reload and regenerate callbacks#907sgpinkus wants to merge 1 commit into
sgpinkus wants to merge 1 commit into
Conversation
Author
|
@import-brain, @dougwilson Any chance merge? |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
January 28, 2024 20:24
9d2e29b to
408229e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? The scope calling regenerate (or reload) does not necessarily want or need to know what a
reqis. Passing the new session object as a callback parameter allows the callback to regenerate or resave then make changes without knowing aboutreq. Example:I specifically wanted this to
Session.regeneratebut added toSession.reloadtoo for consistency. Might also want it inSession.savecallback but that seems to require change in the behaviour of plugins so I gave it a pass.