chore: add missing semicolon#7385
Closed
jackke88 wants to merge 1 commit into
Closed
Conversation
Contributor
|
I know that the style is inconsistent, but the code should follow JavaScript Standard Style (see the Collaborator Guide), which means that there should be no semicolons. Generally we do not accept style-only PRs. Adding linters and formatting configuration is tracked in expressjs/discussions#327. Similar PRs: |
Author
|
Thanks for the review and the pointer to the Collaborator Guide! My apologies for the style-only noise. I'll keep an eye on #327 for the linting updates. Have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a missing semicolon in lib/express.js for consistency.