fix compute instance show: display multiple ssh keys - #900
Merged
Conversation
arthuraliiev
approved these changes
Aug 19, 2026
quentinalbertone
approved these changes
Aug 19, 2026
| }(), | ||
| Name: instance.Name, | ||
| PrivateNetworks: make([]string, 0), | ||
| SSHKey: utils.DefaultString(sshKeyName, "-"), |
Contributor
There was a problem hiding this comment.
suggestion: you can directly allocate InstanceShowOutput.SSHKeys with the size of instance.SSHKeys
Contributor
Author
There was a problem hiding this comment.
I did that for consistency with over zero-initialized arrays in the rest of the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cli (during compute instance show) was still using the deprecated
sshKeyfieldas the source of truth while nowadays it'ssshKeys(plural) that needs to be used as an instance can have multiple ssh keysCreation was already working fine
Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
Before
after