feat(store): add bucket lifecycle support#847
Conversation
d0106d1 to
020c155
Compare
020c155 to
1ff974f
Compare
|
Thanks for your contribution, in grand scheme of things lgtm, I have one tiny issue with some enum handling in the default case, will leave a comment in the code directly. I'm also wondering if the dep bump could have been separated from the feature, separate PRs. |
| case r.Filter.ObjectSizeLessThan != nil: | ||
| return &types.LifecycleRuleFilterMemberObjectSizeLessThan{Value: *r.Filter.ObjectSizeLessThan} | ||
| default: | ||
| return &types.LifecycleRuleFilterMemberPrefix{} |
There was a problem hiding this comment.
Here we return &types.LifecycleRuleFilterMemberPrefix{} when none of the recognised fields are set.
This silently turns any rule with an unrecognised filter into an empty prefix filter rather than erroring.
We might want to add some signal, wdyt?
There was a problem hiding this comment.
We test the happy path, but we might also want ToS3 => FromS3 round-trip test to catch silent field drops, default: case and any future divergence between the two.
Description
falsevalue because they were missing this old check vs new checkChecklist
(For exoscale contributors)
CHANGELOG.md)Testing
get/show/delete config
expiration header