Merged
Conversation
glennj
commented
Apr 9, 2026
Comment on lines
+143
to
+144
| -- do not look for any tests after this line, they won't run in test environment | ||
| break if line\match '-- The next tests are optional.' |
Contributor
Author
There was a problem hiding this comment.
This is the main fix. Bonus tests reside below this marker. They are not run in the test runner, and the runner complains (down below on line 187) if the test output does not match the test bodies.
glennj
commented
Apr 9, 2026
Comment on lines
+187
to
+190
| if not test | ||
| status = 'error' | ||
| results.message = "missing test result for #{name}" | ||
| break |
Contributor
Author
There was a problem hiding this comment.
That assertion was causing tests to error out with "An error occurred while running your tests.". I need to properly return the test results with a more appropriate message.
IsaacG
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus provide better error messages for assertions.