You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is a fixup for the issue #261 I opened 2 months ago.
Eventually it creates a route6-$name file under RHEL Systems when mroute is used so that IPv6 routes can be used.
Therefor the $routes hash first is splitted with $hash.reduce and Stdlib::IP::Address Regex matches into a hash containing only v4 and one only containing v6 routes. Each file has its own default tempalte which uses the the associated variable and the files are only created if a route exists.
Additionally a parameter $route6_tempalte is introduced to overwrite the template file in the same way as it is possilbe for $route_down_template
The change should not interfere with Debian/SUSE Support since it's not touching their templates/variables.
puppet-lint --no-autoloader_layout-check mroute.pp returns no error.
Thanks for the PR, the module is supposed to be Puppet 3 compatible, so the reduce function fails on old Puppet versions (see Travis checks).
As now I've to keep this MR on hold, until we upgrade the major release of the module and make it Puppet >= 4 only compatible.
@chrisongthb I've version 4 ready for some time in https://github.com/example42/puppet-network/tree/version4, but have to do more tests and resync it with latest version of legacy defines, which will be maininted for backwards compatibility.
Release due maybe during xmas break, maybe later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fixup for the issue #261 I opened 2 months ago.
Eventually it creates a
route6-$namefile under RHEL Systems whenmrouteis used so that IPv6 routes can be used.Therefor the
$routeshash first is splitted with $hash.reduce and Stdlib::IP::Address Regex matches into a hash containing only v4 and one only containing v6 routes. Each file has its own default tempalte which uses the the associated variable and the files are only created if a route exists.Additionally a parameter
$route6_tempalteis introduced to overwrite the template file in the same way as it is possilbe for$route_down_templateThe change should not interfere with Debian/SUSE Support since it's not touching their templates/variables.
puppet-lint --no-autoloader_layout-check mroute.ppreturns no error.