fix(group): use array-aware validation for participants - #180
Open
netoduwe wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the group participant endpoint to validate the participants field as an array of numbers, matching the validation already used by group creation and preventing incorrect validation of array-shaped input. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the new validator accepts or rejects the wrong participant list, the endpoint could add, remove, or otherwise store an incorrect group membership, and reverting would not undo memberships already changed. The affected records are bounded and can be repaired, but this is more than an ordinary transient validation bug.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the validation used by
POST /group/participant.The
participantsfield is an array, but the route was usingValidateJIDFields, which handles individual string fields. Valid participant requests were therefore rejected before reachingUpdateParticipant.This change uses the existing array-aware
ValidateMultipleNumbers("participants")middleware, matching the behavior already used by/group/create.Related Issue
Closes #97
Type of Change
Testing
Checklist
Additional Notes
Supersedes #100. This PR was created from the current upstream
developbranch and contains one focused commit changing one file.