Skip to content

Connection manager consolidation#79

Merged
everoddandeven merged 1 commit intomainfrom
connection-manager-consolidation
Apr 7, 2026
Merged

Connection manager consolidation#79
everoddandeven merged 1 commit intomainfrom
connection-manager-consolidation

Conversation

@everoddandeven
Copy link
Copy Markdown
Owner

  • Consolidate connection manager logic
  • Add DockerWalletRpcManager
  • Enable TestMoneroConnectionManager
  • Setup another docker wallet rpc instance
  • Other minor fixes

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 4, 2026

Not up to standards ⛔

🔴 Issues 1 high · 3 medium · 1 minor

Alerts:
⚠ 5 issues (≤ 0 issues of at least minor severity)

Results:
5 new issues

Category Results
Security 1 high
CodeStyle 1 minor
Complexity 3 medium

View in Codacy

🟢 Metrics 16 complexity · -9 duplication

Metric Results
Complexity 16
Duplication -9

View in Codacy

🟢 Coverage 93.00% diff coverage · +3.13% coverage variation

Metric Results
Coverage variation +3.13% coverage variation (-1.00%)
Diff coverage 93.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ae4658b) 18142 15589 85.93%
Head commit (03586e2) 18314 (+172) 16310 (+721) 89.06% (+3.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#79) 657 611 93.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

TIP This summary will be updated as you push new changes. Give us feedback

@everoddandeven everoddandeven force-pushed the connection-manager-consolidation branch 6 times, most recently from b6cf254 to ea962bc Compare April 7, 2026 17:32
@everoddandeven everoddandeven force-pushed the connection-manager-consolidation branch from ea962bc to 03586e2 Compare April 7, 2026 20:05
@everoddandeven everoddandeven merged commit 05ea25c into main Apr 7, 2026
6 of 9 checks passed
@everoddandeven everoddandeven deleted the connection-manager-consolidation branch April 7, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant