Deduplicate withAuth by delegating to ApplyAuth#115
Merged
haasonsaas merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
Single source of truth for auth header logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR SummaryLow Risk Overview This makes Reviewed by Cursor Bugbot for commit 067140d. Bugbot is set up for automated code reviews on this repo. Configure here. |
haasonsaas
added a commit
that referenced
this pull request
Apr 12, 2026
- Restore RealIP + rate limiter + body size + security headers on ConnectRPC path (lost during rebase from pre-#113 branch) - Replace authReq with controlplaneclient.ApplyAuth (dedup from #113) - Replace OutgoingHeaders with ApplyAuth (dedup from #115) - withAuth delegates to ApplyAuth Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
haasonsaas
added a commit
that referenced
this pull request
Apr 12, 2026
* Import identity types from shared proto package Remove local Organization, OrgMember, APIKey message definitions from tenant.proto and import canonical types from identity/v1. Update all converter functions, clients, and tests. Closes #110 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Replace audit.Entry with shared auditv1.Event Swap hand-written Entry struct for auditv1.Event from shared proto. Sink interface accepts []*auditv1.Event. Logger methods construct proto events with nested Actor/Resource. Metadata field overwrite prevented by setting dedicated fields last. CI updated with shared proto symlinks for buf lint and tenant.proto excluded from buf breaking during migration. Closes #108 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Address review feedback: restore middleware, deduplicate auth helpers - Restore RealIP + rate limiter + body size + security headers on ConnectRPC path (lost during rebase from pre-#113 branch) - Replace authReq with controlplaneclient.ApplyAuth (dedup from #113) - Replace OutgoingHeaders with ApplyAuth (dedup from #115) - withAuth delegates to ApplyAuth Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withAuthandApplyAuthincontrolplaneclientboth set the same auth headers. MakewithAuthdelegate toApplyAuthso there's one source of truth.Addresses remaining Bugbot feedback from #113.
Test plan
go build ./...passesgo test ./internal/controlplaneclient/...passes🤖 Generated with Claude Code