Fix thread safety issues in producer-consumer implementation#19238
Open
bkk07 wants to merge 1 commit into
Open
Fix thread safety issues in producer-consumer implementation#19238bkk07 wants to merge 1 commit into
bkk07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes thread-safety issues in the producer-consumer implementation.
The previous implementation accessed a shared LinkedList concurrently without proper synchronization. Queue condition checks and wait/notify coordination were performed outside a shared lock, which could lead to race conditions, missed notifications, visibility issues, and potential queue corruption when multiple producers and consumers executed concurrently.
Changes made:
This preserves the original educational intent of demonstrating wait/notify based producer-consumer coordination while ensuring thread-safe behavior.