feat(generate-transformation-test): honor explicit --from/--to range#141
Open
samcm wants to merge 1 commit into
Open
feat(generate-transformation-test): honor explicit --from/--to range#141samcm wants to merge 1 commit into
samcm wants to merge 1 commit into
Conversation
The --from/--to flags were documented and parsed but never consumed; range discovery always anchored a duration-sized window at the head of available data. That makes it impossible to seed tests for sparse historical events (e.g. Rocket Pool minipool/megapool creations) which never fall in a recent window. Apply the explicit window over the discovered range when supplied: numeric bounds map to block/slot/epoch strategies, others to time strategies, so mixed-axis models keep their heuristic value on the non-overridden axis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--from/--toflags ongenerate-transformation-testwere documented and parsed but never consumed — range discovery always anchored aduration-sized window at the head of available data. That makes it impossible to seed tests for sparse historical events (e.g. Rocket Pool minipool/megapool creations) which never fall in a recent window.This applies an explicit window over the discovered range when supplied: numeric bounds map to block/slot/epoch strategies, non-numeric to time strategies, so mixed-axis models keep their heuristic value on the non-overridden axis.