chore: publish as @ethersphere/core-sdk - #2
Merged
Conversation
Renames the package from @upcoming/swarm-core to @ethersphere/core-sdk, per ethersphere/infra_tasks#94. The @upcoming scope stays in use as the development/staging scope; this is the official release name. - package.json: name -> @ethersphere/core-sdk - package.json: add repository/homepage/bugs/description. The repository field is REQUIRED by `npm publish --provenance` -- without it the publish workflow fails, since provenance has to bind the tarball to a source repo. - LICENSE + package.json license: BSD-3-Clause, matching bee-js and swarm-cli. The repo had no license at all, so npm would have shipped this as UNLICENSED -- wrong for a library intended to be consumed by bee-js and swarm-cli. - release_github.yml: package-name -> core-sdk, and point release-please at the org secret GHA_PAT_BASIC. That is the secret swarm-cli's release-please actually runs on, and core-sdk has now been added to its selected-repositories list. REPO_GHA_PAT was never created here. - README: install line and every import path updated. The README had a third spelling (@ethersphere/swarm-core) that matched neither the package name nor the imports.
The first run of this workflow on main failed, and its log showed two separate problems, not one: ##[warning]Unexpected input(s) 'package-name', 'bump-minor-pre-major' ##[error]release-please failed: Input required and not supplied: token The token error is fixed in the previous commit. The warning is the more subtle one: release-please-action@v5 does not accept `package-name` or `bump-minor-pre-major` as inputs at all. It warns and continues, so the workflow does not fail on them -- it just quietly ignores them. Renaming `package-name` to core-sdk was therefore dead config on its own, and `bump-minor-pre-major: true` was never taking effect, meaning the first breaking change would have cut 1.0.0 instead of 0.1.0. v5 takes these from release-please-config.json + the manifest instead (both at their default paths, so no `config-file` input is needed): - release-please-config.json: release-type node, package-name @ethersphere/core-sdk, bump-minor-pre-major true - .release-please-manifest.json: seeded at 0.0.8, the current version Also adds the contents/pull-requests write permissions the action needs. swarm-cli pins @v2, where both inputs are still valid -- which is why the copied-over config looked correct.
darkobas2
force-pushed
the
chore/publish-as-ethersphere-core-sdk
branch
from
August 18, 2026 11:43
e425e3c to
e900705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the code side of ethersphere/infra_tasks#94.
Rebased onto @slapec93's
chore: rename package to public name— hisversion: 0.0.1is kept, and the release-please manifest is seeded to match it.Already done outside this PR
npm publish --provenancepublishenvironmentGHA_PAT_BASICmainbranchIn this PR
package.json—repository,homepage,bugs,description.repositoryis not cosmetic:npm publish --provenancerequires it, because provenance binds the tarball to a source repo. Without it the publish workflow fails even with everything else correct.LICENSE +
license: BSD-3-Clause. The repo had no license and nolicensefield, so npm would have published this asUNLICENSED— wrong for a library meant to be consumed by bee-js and swarm-cli. BSD-3-Clause matches both of those. @slapec93 this is the one thing here I chose rather than looked up, so please confirm it.release_github.yml— two separate bugs. The run onmainfailed with:The token error is just the missing secret — now
secrets.GHA_PAT_BASIC, the org secret swarm-cli's release-please actually runs on, and core-sdk has been added to its allowlist.REPO_GHA_PATwas never created on this repo.The warning is the subtler one. release-please-action@v5 does not accept
package-nameorbump-minor-pre-majorat all — it warns and carries on, so nothing fails loudly, butbump-minor-pre-major: truewas never in effect and the first breaking change would have cut1.0.0instead of0.1.0. swarm-cli pins@v2, where both inputs are still valid, which is exactly why the copied config looked right. v5 takes these fromrelease-please-config.json+.release-please-manifest.json(both at default paths), added here. Also adds thecontents/pull-requestswrite permissions the action needs.README — the install line said
@ethersphere/swarm-coreand the imports said bareswarm-core/..., a third name matching neither package.json nor reality. All now@ethersphere/core-sdk.Still blocking the first publish
publish_npmjs.ymlpasses noNODE_AUTH_TOKEN, and swarm-cli'spublishenvironment holds no secret either — those releases run on npm Trusted Publishing (OIDC). That has to be registered on npmjs.com against this package (repoethersphere/core-sdk, workflowpublish_npmjs.yml, environmentpublish) byethersphereownerorethswarm-devops. Until it exists the first publish fails regardless of this PR.@ethersphere/core-sdkis currently unclaimed on npm.