Skip to content

fix: limit interfaces in test - #5567

Open
sbackend123 wants to merge 1 commit into
masterfrom
fix/libp2p-checkaddressbook-truncate-underlays
Open

fix: limit interfaces in test#5567
sbackend123 wants to merge 1 commit into
masterfrom
fix/libp2p-checkaddressbook-truncate-underlays

Conversation

@sbackend123

Copy link
Copy Markdown
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Libp2p unit tests were listening on :0, so host.Addrs() expanded to every local interface. On machines with many docker/bridge NICs that list exceeds handshake’s 20-underlay cap, and TestTopologyNotifier / TestTopologyAnnounce failed comparing the addressbook to the full listen set.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

AI Disclosure

  • This PR contains code that has been generated by an LLM.
  • I have reviewed the AI generated code thoroughly.
  • I possess the technical expertise to responsibly review the code generated in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant