Skip to content

feat: add new metrics - #5565

Draft
sbackend123 wants to merge 2 commits into
masterfrom
feat/libp2p-connection-transport-metrics
Draft

feat: add new metrics#5565
sbackend123 wants to merge 2 commits into
masterfrom
feat/libp2p-connection-transport-metrics

Conversation

@sbackend123

@sbackend123 sbackend123 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

  • Add transport label to libp2p created/handled connection metrics (tcp / ws / wss / quic*).
  • Move /wss + QUIC classification into bzz.ClassifyTransport.
  • Replace separate public/private counters with public="true|false" on handled_connection_count.
  • Pre-init label series so unused transports show as 0, not missing.

Breaking changes

  • created_connection_count / handled_connection_count: Counter → CounterVec.
  • handled_connection_count now has labels {transport, public}.
  • Removed public_address_connections_total / private_address_connections_total — use handled_connection_count{public=...} instead.
  • Dashboards using count(...) as a denominator will under-count after upgrade; prefer sum by (...).

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

#5506

Screenshots (if appropriate):

AI Disclosure

  • This PR contains code that has been generated by an LLM.
  • I have reviewed the AI generated code thoroughly.
  • I possess the technical expertise to responsibly review the code generated in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant