fix: add bounds checking for data offset in joiner readAtOffset#5522
Open
nugaon wants to merge 1 commit into
Open
fix: add bounds checking for data offset in joiner readAtOffset#5522nugaon wants to merge 1 commit into
nugaon wants to merge 1 commit into
Conversation
acud
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds bounds checking to the leaf branch of
(*joiner).readAtOffsetinpkg/file/joiner/joiner.go. A malformed parent intermediate-chunk span can drive the recursion into the leaf path withdataOffsetStartbeyondlen(data), producing an inverted slice range and a runtime panic. The offsets are now validated and rejected asErrMalformedTrieinstead of crashing the node, consistent with the existing malformed-trie handling in the same function.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Reported panic, most likely caused by an externally malformed (erasure-coded) chunk whose parent span does not match the actual data:
With a corrupted parent span,
dataOffsetStart = 16384exceedslen(data) = 4096, makinglenDataToCopynegative and yieldingdataOffsetEnd = 4096, sodata[16384:4096]panics. Parity shard spans are GF(2⁸) combinations of data-chunk spans and are not meaningful values, so a corrupted span must be treated as malformed rather than trusted.Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure