Skip to content

Fix node version parsing in installer script - #8234

Closed
Gared wants to merge 1 commit into
developfrom
fix-installer-node-version
Closed

Gared wants to merge 1 commit into
developfrom
fix-installer-node-version

Conversation

@Gared

@Gared Gared commented Sep 17, 2026

Copy link
Copy Markdown
Member

This fixes #8214

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Fix Node.js version parsing in PowerShell installer

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Parses the Node.js major version without quote-sensitive string splitting.
• Restores reliable minimum-version validation in the Windows installer.
High-Level Assessment

The parseInt-based expression is the most direct fix because it avoids nested quoting while preserving the existing numeric comparison. PowerShell-side version parsing would add unnecessary complexity.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
installer.ps1Fix Node.js major-version parsing +1/-1

Fix Node.js major-version parsing

• Replaces string splitting with JavaScript parseInt when extracting the installed Node.js major version. This avoids PowerShell argument-quoting issues during prerequisite validation.

bin/installer.ps1

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@Gared Gared closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure with Etherpad installer

1 participant