Bookmark save/restore with library load awareness!#906
Merged
Conversation
…saved/restored in all modules (heap/stack is kinda a wild card, but not too much we can do about that). Only real annoyance is minor, and that is that they aren't restored upon _start, but only once ld has loaded the modules they reside in. Might be able to hack around that though...
…re efficient to just default construct a QString also added preliminary label support (Not module aware yet)
NOTE: the current approach has one fatal flaw, and that is that the modules are no longer loaded after the application exits, so we lose the information and cannot properly save the bookmarks/labels/etc. I think we need to store the module when we add the bookmark itself so we know it immediately.
…there's still a bunch to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a bit of a brute force approach but works! now bookmarks are saved/restored in all modules
(heap/stack is kinda a wild card, but not too much we can do about that).
Only real annoyance is minor, and that is that they aren't restored upon _start, but only once ld has loaded the modules they reside in. Might be able to hack around that though...