IEP-1763 Missing Eclipse Marketplace in Espressif-IDE#1455
Conversation
📝 WalkthroughWalkthroughAn Eclipse product descriptor adds the marketplace client feature ( ChangesMarketplace Client Feature Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
releng/com.espressif.idf.product/idf.product (1)
97-97:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRepository URL uses HTTP instead of HTTPS.
http://download.eclipse.org/releases/latest/transmits over plain HTTP. Even though this repository is currently disabled, it is worth correcting tohttps://download.eclipse.org/releases/latest/to prevent any future MitM risk if the repository is re-enabled.🔒 Proposed fix
- <repository location="http://download.eclipse.org/releases/latest/" name="" enabled="false" /> + <repository location="https://download.eclipse.org/releases/latest/" name="" enabled="false" />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@releng/com.espressif.idf.product/idf.product` at line 97, Update the repository element that currently has location="http://download.eclipse.org/releases/latest/" to use HTTPS instead; locate the repository XML element (the <repository ... /> entry with the location attribute) in idf.product and change the location value to "https://download.eclipse.org/releases/latest/" so the repository URL is served over HTTPS even while disabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@releng/com.espressif.idf.product/idf.product`:
- Line 97: Update the repository element that currently has
location="http://download.eclipse.org/releases/latest/" to use HTTPS instead;
locate the repository XML element (the <repository ... /> entry with the
location attribute) in idf.product and change the location value to
"https://download.eclipse.org/releases/latest/" so the repository URL is served
over HTTPS even while disabled.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 63f5d0d3-461d-4bc1-bd38-5c21e942989d
📒 Files selected for processing (1)
releng/com.espressif.idf.product/idf.product
AndriiFilippov
left a comment
There was a problem hiding this comment.
@sigmaaa hi !
Tested on Windows 11 / Mac arm64
Marketplace is here and fully functionable ✔️
LGTM 👍
Description
Added eclipse marketplace feature to the idf.product, so the eclipse marketplace is available in the Espressif-IDE by default
Fixes # (IEP-1763)
Type of change
Please delete options that are not relevant.
How has this been tested?
Download Espressif-IDE from this PR -> test that eclipse marketplace present there and it's functional
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit