[codex] fix catalog alias projections#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes field alias handling for qualified catalog queries.
Root Cause
Some catalog handlers were using the displayed alias name as the data lookup key, while others ignored aliased projections or ignored projection entirely. Qualified catalog queries such as
pg_catalog.pg_roles,pg_catalog.pg_namespace,pg_catalog.pg_database, andinformation_schema.schematacould therefore drop aliased columns or return values from the wrong source column.Changes
pg_namespaceuse normal projection handling instead of always returning all columns.Fixes #77.
Verification
cargo test --test catalog_alias_test --test catalog_test --test information_schema_test --test pg_database_test --test pg_roles_user_test