Update ci-run to allow upload of junit results - #5147
Conversation
Signed-off-by: Ethan Truong <ethantruong@google.com>
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
probably it would be better to make upload-artifact work the same way download-artifacts - ie with a foreach
Upload step loops through the `uploads` rather than require individually named parameters. Signed-off-by: Ethan Truong <ethantruong@google.com>
I've added a new |
|
snap! #5155 i started testing it but didnt get far i think remove all backwards compat - esp the junit ones theres no junit landed yet - but i think we should just remove the upload-artifact altogether - envoy is the only consumer so cleaner to break on that point - in my impl i made it a yaml config - so you can set things like fail-if-not-found or somesuch |
I think your PR looks great! Should we close this one in the meantime? Happy to re-open later if it becomes relevant. |
|
probably yep - just because it has a little extra in terms of configurability - apologies for taking over - mostly it was because i knew this was going to need to be tested before we land in envoy |
Not at all! This was not my wheelhouse at all, so I'm happy for an actual expert to take over. |
2 participants
No description provided.