tls: allow multiple TLS certificates in the upstream when using a custom TLS certificate selector - #46479
Open
Berro321 wants to merge 8 commits into
Open
tls: allow multiple TLS certificates in the upstream when using a custom TLS certificate selector#46479Berro321 wants to merge 8 commits into
Berro321 wants to merge 8 commits into
Conversation
a custom tls cert selector is used for the upstream. Signed-off-by: Berro321 <matchburn321@gmail.com>
|
Hi @Berro321, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Berro321
had a problem deploying
to
external-contributors
July 31, 2026 05:45 — with 
GitHub Actions
Error
GitHub Actions
Error
Signed-off-by: Berro321 <matchburn321@gmail.com>
Berro321
had a problem deploying
to
external-contributors
July 31, 2026 20:29 — with
GitHub Actions
Error
GitHub Actions
Error
Signed-off-by: Berro321 <matchburn321@gmail.com>
Berro321
temporarily deployed
to
external-contributors
July 31, 2026 20:57 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Berro321
marked this pull request as ready for review
July 31, 2026 21:18
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
Assigning @botengyao as codeowner |
Berro321
temporarily deployed
to
external-contributors
August 5, 2026 22:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Author
|
/retest |
Berro321
had a problem deploying
to
external-contributors
August 7, 2026 20:14 — with
GitHub Actions
Error
GitHub Actions
Error
Signed-off-by: Berro321 <matchburn321@gmail.com>
Berro321
had a problem deploying
to
external-contributors
August 11, 2026 19:30 — with
GitHub Actions
Error
GitHub Actions
Error
Author
|
/retest |
Berro321
requested a deployment
to
external-contributors
August 12, 2026 17:33 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Allow multiple TLS certificates in the upstream tls context when using a custom TLS certificate selector. The single cert check is kept if one is not defined.
Additional Description: We are working on an internal TLS certificate selector for UpstreamTLSContext that can select between multiple client certificate. By default only one is allowed, so we need a way to allow multiple once our custom TLS certificate selector is enabled.
Risk Level: Medium
Testing: Added unit tests, tested manually to check it works with our custom cert selector.
Docs Changes: Added documentation in the API proto for
tls_certificatesto indicate multiple certs are allowed in a client context when a custom TLS certificate selector is used.Release Notes: Added a release note under new features.
Platform Specific Features: N/A